[DataPipe] Adding a 's' to the functional names of open/list DataPipes #479
Conversation
[ghstack-poisoned]
ghstack-source-id: 3bb1bce0576bc0ef5c298bf7bbc85b88bc8d4945 Pull Request resolved: #479
facebook-github-bot
added
the
CLA Signed
I don't think there are any existing use cases in tests but I have added some. |
…st DataPipes" [ghstack-poisoned]
ghstack-source-id: c2d9ee08447c04e6a116943b5fb03b70edf1c722 Pull Request resolved: #479
…st DataPipes" [ghstack-poisoned]
ghstack-source-id: 20d002fe1a679e4795f2afd7016dd0a22497c7d5 Pull Request resolved: #479
| # Register for functional API for backward compatibility | ||
| IterDataPipe.register_datapipe_as_function("open_file_by_fsspec", FSSpecFileOpenerIterDataPipe) |
There was a problem hiding this comment.
As a follow-up task, add deprecation warning for the functional API.
There was a problem hiding this comment.
It seems like we will need to change the registration function and IterDataPipe class in PyTorch core to do that. One possibility is described here.
Do you think we should land this PR as it is or make the changes to core first?
There was a problem hiding this comment.
Let's land this PR first and change the core afterwards.
There was a problem hiding this comment.
And, could you please update the deprecation table as well?
|
@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: Pull Request resolved: #479 Test Plan: Imported from OSS Reviewed By: ejguan Differential Revision: D36785643 Pulled By: NivekT fbshipit-source-id: 02c3071047ac00dd34cb83a9b392be0cfa3565b0
) Summary: Pull Request resolved: pytorch#479 Test Plan: Imported from OSS Reviewed By: ejguan Differential Revision: D36785643 Pulled By: NivekT fbshipit-source-id: 02c3071047ac00dd34cb83a9b392be0cfa3565b0
Stack from ghstack:
Differential Revision: D36785643